Add get_defaults method to allow sub-class to customize parameter loading #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdebacker you mind if I merge this? |
|
@hdoupe No problem with you merging this, but I had been working off of this branch and was unable to use this how I wanted. That's surely my problem, but I might want to follow up with you for a little more guidance. But if this PR is ready, can you bump the version and we'll make a new release with this functionality? |
jdebacker
approved these changes
Nov 22, 2024
|
Can you confirm that this change is fully backwards compatible? It seemed to work find in Tax-Calculator, but I wanted to be sure more broadly. @hdoupe If this PR is ready to go, let me know and I will merge it. I was able to use these changes to do what I needed in Tax-Calculator with respect to extending the range of years in the default parameters JSON file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdebacker , let me know if this works for you. You can override the
get_defaultsclass intaxcalc.Parametersand change this value in the JSON to use the new last year value.https://github.com/PSLmodels/Tax-Calculator/blob/b41af537803488b6ac40beb0a0e0a7e81cfb6dbd/taxcalc/policy_current_law.json#L9